Timur Sağlam

Results 87 comments of Timur Sağlam

> * Is the `hasBaseCode` option is really necessary in `GreedyStringTiling` ? https://github.com/jplag/JPlag/blob/master/jplag/src/main/java/de/jplag/GreedyStringTiling.java#L224. From what I understand, `token.basecode` can only be true if `hasBaseCode()` is also true. I would assume...

Just to clarify, @csidirop in your scenario you have students altering the basecode parts in their submission, thus hindering JPlag to detect the basecode parts and not properly counting it...

Lightweight frontend test cases that do not depend on the JPlag core can now be defined in the frontend projects themselves. For details see #408.

Closed, as we currently employ lightweight language module tests that do not depend on the JPlag core.

We should also clarify that we consider the text/char frontends as severely outdated, as more modern (ML/NLP-based) methods might be way better to detect plagiarism in natural language texts. Thus,...

> Also the test time increases from about 10 seconds to over 30. If a language has even more test data, this could lead to a significantly increased test runtime....

@SuyDesignz can you resolve all review comments that you addressed? If you are waiting for feedback in a comment just tag the reviewer again.

> I tried to change the classes of the json objects to records. Here I ran into some problems with the deserialization. Apparently there are already some entries about this:...

@SuyDesignz when I run `mvn clean package assembly:single` locally with your branch, it produces junk files in the `jplag/jplag` directory. This is probably unintended, right? ![grafik](https://user-images.githubusercontent.com/4396919/186099524-3c01cd4b-3ac9-4728-890f-2e90cdc50d76.png)

Regarding intuition, the methods of the comparison class are clearly documented, so it should be really obvious that it is a percentage. I am not entirely convinced, that switching to...