TrymPet

Results 28 comments of TrymPet

Just got an M1 mac, so I will probably finish the view and bindings in the not-so-distant future

I don't think MVVM bindings is possible in Xamarin.Mac, since Cocoa (which Xamarin mac is built on top of) is an MVC framework. Xamarin.Mac is nothing like the other flavors...

Cool, I'll submit a PR soon.

@Jellyfrog, the 7.3 and linter tests should pass now

> Please add test data so we can ensure your change is not broken in the future. > > Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units The `IPMIClient` and...

Thank you! 😎 Yes, refactoring the module to a class would make it testable. I will submit a new pr once I have time.

@murrant, review pretty please 😃

@murrant sure, apologies for the delay. :smile: > It seems like SDR should be read during discovery and then polling should fetch based on SDR. This would match the semantics...

> Sorry that we've not got this in a while @trympet. This PR now has a couple of conflicts since you created it, would you mind updating this PR and...

> Any update on the mac compatible version? If all you need is to browse the internet, you could check out my repo. It's pretty rudimentary, but has served me...