Trustin Lee comments

Results 271 comments of


                                            Trustin Lee

How do I use Javadoc agent with Gradle?

Gentle ping :pray:

How do I use Javadoc agent with Gradle?

Thanks, @rsmckinney!

Rename Rpc* to Thrift*

I'm not sure renaming is a scalable approach. What happens if we add support for other RPC protocols, say JSON-RPC, Hessian, RSocket etc? Why not just make `RpcRequest/Response` a `StreamMessage`...

Rename Rpc* to Thrift*

As a stopgap solution, how about checking if RPC decorators are present in pure HTTP clients and raising an exception?

Add support for xDS based `EndpointGroup`

I guess you're going to update this PR again once #5610 is merged, right, @jrhee17?

Fix blocking annotation not working on gRPC calls properly

Both are fine by me. Let me know if you need this PR to be merged, we'd be happy to accept it given it will take quite some time until...

Allow customizing the `MeterIdPrefix` of `CircuitBreaker` metrics(#5318)

I think we should go with Micrometer Observation as described at #5736. Sorry but let me close this. :bow:

Allow customizing the `MeterIdPrefix` of `CircuitBreaker` metrics.

@minwoox, @Kyurenpoto I think we should go with Micrometer Observation as described at #5736. Sorry but let me close this. :bow:

Support content encryption within CentralDogma

Instead, we could consider encrypting the entire repository? https://git-annex.branchable.com/tips/fully_encrypted_git_repositories_with_gcrypt/

Support distributed tracing

We might want to wait for `Micrometer Tracing` integration in Armeria first though