Trustin Lee
Trustin Lee
Thanks for continuing updating this PR. Please feel free to let us know when it's ready for reviews. If you feel it's not yet, please consider switching it to a...
I think it's fine to add `setBlockingTaskExecutor()` as long as we enforce the following restrictions to prevent the situation where `blockingTaskExecutor()` returns two different instances: - `setBlockingTaskExecutor()` throws an `IllegalStateException`...
An alternative option is to provide a way to create a service per gRPC method, e.g. ```java List services = GrpcService .builder() ... .buildPerMethod(); services.forEach(s => { serverBuilder .route() .blockingTaskExecutor(...)...
A map of Route and GrpcService also sounds good to me. GrpcService implements HttpServiceWithRoutes so you can get its routes via `GrpcService.routes()` though.
@ikhoon That also will work. It will also work better for annotated services because an annotated service's method has its own `ServiceConfig`. However, I'm somewhat concerned about such a change...
Approved by mistake. Sorry! 🙏
@anuraaga @mauhiz Do you remember anything about this when we chose the above defaults?
Gentle ping
will be nice if we integrate with libraries such as Hibernate Validator.