Joe Pea

icon indicating a website link http://lume.io icon indicating an email [email protected]

icon location Los Angeles, CA, USA, Earth icon location Crafting interfaces between humans and machines. Worked: SpaceX, @nasa, Velodyne Lidar, IMVU

Results 1899 comments of Joe Pea

fix: endless concat

Oops, this went into the `master` branch, but we are now using `main` instead of `master`. I will fix it. Thanks for the contribution!

Clock synchronization issue

Will close after thinking again about this because the expectation is that if we want to manage time ourselves, we can pass in the values to both `start(time)` and `update(time)`,...

Add test for calling a tween's update() method with no arguments.

Closed in https://github.com/tweenjs/tween.js/pull/605

Keep website and README in sync

This has been handled, the website is published from our `main` branch (we don't use `master` anymore). So, simply merge any PR to `main` and the website gets updated. Yay.

Multiple `.start()` and `.to(prop:[])`

Closes #378

Multiple `.start()` and `.to(prop:[])`

Looks like this got fixed already! https://codepen.io/trusktr/pen/XWGpKyX/10faa7d954bf016a3f0261ca626db17e?editors=1010 There's a similar issue with `startWithCurrentValues()`, but the problem is gone when using `start()`. See this issue: - https://github.com/tweenjs/tween.js/issues/378

if stop each tween after in onComplete() callback it went wrong.

The code has changed a big since 2016. If still any problem, please feel free to open a new issue including a reproduction example that we can run.

Animation on repeat speeds up over time.

Looks like this is still reproducible in v22, and in particular it looks like it happens with the new `startFromCurrentValues()` method which used to be the default behavior in v16.6:...

Make a reset method (allows tween reuse in an object pool for example)

Closing, as I believe that `stop`ping and re-`start`ing a tween is a good enough way to reset a tween for this rare use case. If there's a use case where...

Animating on discrete values (integers instead of floats)

Looks like none of us have intent or time to make a PR for this, and workarounds exist. Also I'm not sure we should support rare cases like this directly...