Joe Pea

Results 1899 comments of Joe Pea

> Oh I see you invited me to join the org too. I'm not going to at this point; one reason is that I feel a bit uncomfortable about it...

Alright folks, the great work from @regorxxx and @taisukef is merged. The code is now all ES Modules: https://github.com/chroma-js/chroma.js Unlike your fork @taisukef, this keeps `package.json` and scripts for building...

I force pushed to https://github.com/chroma-js/chroma.js as there was one small mistake in the merge with an import path, now the `test/html/*.html` files all work as expected. @taisukef curious to see...

Aaaaaaalrighty! An initial working test for Deno is pushed @taisukef. ```js "test:deno": "deno run test/test-deno.js", ```

Most tests passing in Chrome browser running as vanilla ES Modules. Need to iron a few out: ``` Chrome: |██████████████████████████████| 50/50 test files | 1956 passed, 69 failed Finished running...

@regorxxx @taisukef there's one particular test where the numbers are quite different between both of your forks. I'm wondering why that is. Here are the tests in question: https://github.com/chroma-js/chroma.js/blob/340438a65d16e594e587f7fe72b98b0f924294d6/test/bezier.test.js#L133-L238 Both...

> The original repo had wrong values and wrong tests. > Also see this: #228 > documented on the changelog ;) @regorxxx ah, thanks! > if I find working with...

> @trusktr Not a browser related context, but [foobar2000](https://www.foobar2000.org/). There are JS plugins for it, to create any frontend/backend element, so I can use most libraries with full support for...

Changing from `foo = 123` to `this.foo = 123` in _pre-existing_ code is a forced change. The _pre-existing_ code also uses decorators, and ergonomics would be lost in moving things...

> it's a forced change within your class that does not cause a breaking change Sure, I can change how my class is implemented, so that people instantiating my class...