NAHO

Results 375 comments of NAHO

> > > Should manual backports request review by default? > > > > [...] > > > > There's also the potential that things work differently on the release...

> Having separate options for light and dark themes seems redundant at least for the time being, since the rest of Stylix only supports setting a single theme The current...

> Polarity is just an input to guide the palette generator - it could be set to `"either"` or it could not match the color scheme at all, particularly when...

On second thought, it might be better to upstream (NixOS, Home Manager, nix-darwin, and Nix-on-Droid) this as general config hot reloading. If that is the case, we should close this...

> A small number of Home Manager modules already have this. There's an `onChange` option for files which can be used to trigger the reload only when a relevant file...

> Not sure I agree with the move, in the original PR the idea was that vicinae is a program that has an optional service component so it was namespaced...

> > I am not entirely sure about the Home Manager convention, but would it not be better to move only the service-related code from programs.vicinae.systemd into services.vicinae, resulting in...

> To streamline backporting for Stylix maintainers, PR authors could indicate whether their PR can be backported. This is handled in https://github.com/nix-community/stylix/pull/1756. > Ideally, the label CI would automatically add...

> > Ideally, the label CI would automatically add the backport label when a new checkbox (phrasing subject to improvement) is checked: > > This is still to be done....

> we could add `!targets.genericLinux.enable` to hm qt's autoEnable to reduce the number of people who will run into this issue. This option should be enabled by default and would...