stylix icon indicating copy to clipboard operation
stylix copied to clipboard

ci: automate backport labeling with PR checkbox

Open trueNAHO opened this issue 5 months ago • 5 comments

To streamline backporting for Stylix maintainers, PR authors could indicate whether their PR can be backported.

Ideally, the label CI would automatically add the backport label when a new checkbox (phrasing subject to improvement) is checked:

  • [ ] Backport this PR
  • [X] Backport this PR

This probably does not fit in the current "Things done" section:

https://github.com/nix-community/stylix/blob/5cd1e4ffd9d1ad06d5dc3c3b08d8687ce95e4a08/.github/PULL_REQUEST_TEMPLATE.md?plain=1#L9-L14

Either we inconveniently add a seperate section for this one checkmark, or the "Things done" section is appropriately renamed.

trueNAHO avatar Jul 06 '25 20:07 trueNAHO

Either we inconveniently add a seperate section for this one checkmark, or the "Things done" section is appropriately renamed.

perhaps something "Info" or "Info for Reviewers", based on the comment below

0xda157 avatar Jul 06 '25 21:07 0xda157

Would be useful to also list the conditions where backporting is appropriate

danth avatar Jul 08 '25 13:07 danth

To streamline backporting for Stylix maintainers, PR authors could indicate whether their PR can be backported.

This is handled in https://github.com/nix-community/stylix/pull/1756.

Ideally, the label CI would automatically add the backport label when a new checkbox (phrasing subject to improvement) is checked:

This is still to be done.

trueNAHO avatar Jul 25 '25 17:07 trueNAHO

Ideally, the label CI would automatically add the backport label when a new checkbox (phrasing subject to improvement) is checked:

This is still to be done.

For about a month I noticed the stylix-automation bot sometimes adding the backport label. Whatever is causing this is bad because it adds the label when it is not supposed to. See https://github.com/nix-community/stylix/pull/1969 as a great example on its persistence.

trueNAHO avatar Nov 20 '25 16:11 trueNAHO

Ideally, the label CI would automatically add the backport label when a new checkbox (phrasing subject to improvement) is checked:

This is still to be done.

For about a month I noticed the stylix-automation bot sometimes adding the backport label. Whatever is causing this is bad because it adds the label when it is not supposed to. See #1969 as a great example on its persistence.

this was done here to ensure our ci doesn't get out of sync, but I'll revert it as it seems to be causing too many issues.

0xda157 avatar Nov 20 '25 20:11 0xda157