trossimel-sc comments

Results 13 comments of


                                            trossimel-sc

Add for await of

@avp Hi! Do you have any feedback on this PR? Thank you 😄

Add for await of

@avp I just noticed we also need to define `Symbol.asyncIterator` as it's undefined in hermes. Edit: Added 👍

Add for await of

Thanks @avp, One last thing: do you know how to address IR errors that occur after adding `genYieldOrAwaitExpr` as part of the try/catch block in `_emitIteratorCloseImpl` ? I didn't expect...

While the output is correct, I've noticed that when running in debug mode, it occasionally fails with the following message: ``` Assertion failed: (I->hasOutput() && "Instruction has no output"), function...

Add with statement support

Thanks for the response and the assistance @tmikov Just wanted to update, I'm still waiting for my request to be approved by the company. Unfortunately, it's taking longer than expected,...

Bug in scoped function promotion (non-strict mode)

@tmikov it's just being used for testing this behaviour

Accessors are slower than regular property reads

I see, thank you. Is this difference caused by hermes' internal implementation, or should this behaviour be expected for other engines too? I tried with quickjs, and noticed similar results...

Accessors are slower than regular property reads

Thank you for the detailed response @tmikov !

Fix function hoisting behaviour (non-strict mode)

Seems like the failing errors are due to auto generated checks