Rajan Tiwari
Rajan Tiwari
@aldeed I was checking the queries and found out these pagination queries are missing `offset` params, ``` groups, roles, productsByTagId, tags, ordersByAccountId, discountCodes, surcharges, getFlatRateFulfillmentRestrictions ``` I can work on...
thanks @focusaurus , I have started some work on this, should finish all of them soon @bayareacoder .
@focusaurus I think all the PRs above cover pretty much all remaining queries not having `offset` params, Please review these PRs and let me know if they look good.
Thanks @bpietraga . You saved my day.
@aldeed since we have deprecated `currencies` field in Shop, Can we close this as well? ref: [shop/simpleSchemas.js#L694](https://github.com//reactioncommerce/reaction/blob/e39ff79c1c6bb5b0d19ef7993d5be053786abc41/src/core-services/shop/simpleSchemas.js#L694)
hey @kpacha I had done most of the changes but I verified again from the doc and I got following logs, which clearly indicates none of the modifier were loaded...
I am not sure but does it have something to do with this line ? https://github.com/luraproject/lura/blob/633684c4153c429a62fe7299b401dbdf9a1dc811/proxy/plugin/modifier.go#L47
I guess that was the missing piece, seems to be working now thanks @kpacha here is the working example https://github.com/trojanh/krakend-plugin-modifier/blob/master/krakend.plugin.json Also updated the missing documentation for this along with updated...
updated the command in docs as per @kpacha suggestions https://github.com/devopsfaith/krakend-documentation/pull/153/files