reek

reek copied to clipboard

Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. Release notes Sourced from rubocop's releases. RuboCop 1.34.1 Bug fixes #10893: Fix an error when running rubocop without bundle exec....

dependabot[bot]

TooManyMethods only checks instance methods

2

https://github.com/troessner/reek/blob/master/lib/reek/smell_detectors/too_many_methods.rb#L39 > TODO: Only checks instance methods! I resolved the todo above.

whiteleaf7

Inconsistent reporting for FeatureEnvy when using module_function and/or private_class_method

4

The following code ``` module Admins class refers to 'user' more than self (maybe move it to another class?) Goes away if I use def self.active_users. (prepend self) The same...

pardaloupa

False positive for DuplicateMethodCall with case statement

6

Given the following code: ~~~ ruby def method case x when :a if y.method || a.method end when :b if y.method || b.method end end end ~~~ reek reports a...

gettalong

Do not raise Utilityfunction for methods defined in a class_method block

7

Addresses https://github.com/troessner/reek/issues/1538 This PR implements a way to not raise `UtilityFunction` warning for methods defined in `class_methods` block

mateusluizfb

False positive of UtilityFunction for class methods

3

Hi there I've observed a false positive for UtilityFunction when class methods are defined under `class_methods` block of `ActiveSupport::Concern` For instance ```ruby module SomeModule extend ActiveSupport::Concern class_methods do def some_method(arg1,...

VladYermakov

FeatureEnvy and small methods

3

I'm really beginning to dislike the FeatureEnvy detector for small methods: ```ruby def common_parameters_equal?(other_parameters) smell_warning.parameters.values_at(*other_parameters.keys) == other_parameters.values end ``` Should we make this less strict? Require a larger difference? More...

mvz

Use XDG standard for finding config files?

6

I still need to look into it more, but this looks interesting: https://rubyworks.github.io/xdg/

mvz

Rule request: abstruse conditionals

2

Hello! 🙂 Lately I've been working on cleaning up a lot of old code in RuboCop, and one of the most common patterns that has appeared is overly abstruse conditionals,...

Drenmi

directories in config relative to cwd, not to configuration file itself.

1

## Setup Rails app, where helpers smell of _UtilityFunction_ ### _.reek.yml_ ```yml directories: "app/helpers": UtilityFunction: enabled: false ``` ### _app/helpers/foo_helper.rb_ ```ruby module FooHelper def smelly_method(bar) bar.presence end end ``` ##...

leonelgalan