Chris Cotter
Chris Cotter
Currently the Reader uses the XML API to download objects from GCS, due to performance differences as of a few years ago. These differences are much smaller or nonexistent these...
While doing #6370 I noticed that `ShouldRetry` is referenced directly from some methods in grpc_client.go. This means that these methods do not honor the user-configured WithErrorFunc RetryOption, if it has...
Export the default func to determine whether an error is retryable. This makes it easier for users to use the WithErrorFunc option without copying a lot of code. Fixes #6362
Add dual transport tests for HMAC keys and for PostPolicyV4. One PostPolicyV4 test creates a second client with custom key behavior. I left this as a TODO for now but...
Issues: #1438 #1863 #1740 #1475 #1267 #2643 Past attempts at fixes from the community: #2481 , https://code-review.googlesource.com/c/gocloud/+/50430 (mentions something like [datastore.PropertyLoadSaver](https://pkg.go.dev/cloud.google.com/go/datastore?tab=doc#PropertyLoadSaver) as a potential model for a solution. We've seen...
We found via profiling that copy to/from the leftovers buffer was using extra CPU. This removes that additional layer of copying. Reader integration tests pass including the ObjectReadChunksGRPC test which...
In #2190 I tried to add two new upload cases including 408 errors. One of them was fine, but the case `"instructions": ["return-503-after-8192K", "return-408"]` failed with the following error on...
Storage supports CustomTime to millisecond precision so we should use additional precision if possible. Fixes #8422