Frederik Seiffert

Results 227 comments of Frederik Seiffert

Might be the `patch` or `sed` utilities missing, see here for details: https://github.com/firebase/firebase-cpp-sdk/issues/1451#issuecomment-2012424946

I found that the build scripts require the `patch` and `sed` utilities, which on Windows you can install e.g. via Chocolatey: ``` choco install patch sed ```

@jonsimantov I hope I made the right changes based on your feedback - if not please let me know. Any chance you could trigger the CI to run with this...

Thanks for checking – can you try again with the latest changes now please?

Thanks @jonsimantov! I tried the build and it works great for me using the LLVM toolchain. One thing I noticed is that the firebase_cpp_sdk_windows.zip artifact itself contains another ZIP file,...

Hmm ok, so the issue here is all these `error LNK2001: unresolved external symbol` errors, right? Any idea how they could be caused by this change? Is this also a...

@aganea would you be able to take a look at these errors? Unfortunately I’m a bit lost about how this change might be causing them.

I rebased the branch onto the latest main. @jonsimantov could you please run the tests once more to see if these linker errors are still happening? 🙏

Thank you @jonsimantov! It seems like the packaged library is missing a bunch of symbols. Since the `-L` flag we’re adding in this patch is also making the packaging script...

We’re seeing what looks like the same crash (in `remote_config_response.cc:98`). I’ve reported the details in #1433.