firebase-cpp-sdk icon indicating copy to clipboard operation
firebase-cpp-sdk copied to clipboard

[Bug] Crashes at RemoteConfigResponse related to FlatBufferBuilder

Open feixuwu opened this issue 2 years ago • 4 comments

[READ] For Firebase Unity SDK question, please report to Firebase Unity Sample

Once you've read this section and determined that your issue is appropriate for this repository, please delete this section.

[REQUIRED] Please fill in the following fields:

  • Pre-built SDK from the website or open-source from this repo: 10.3.0
  • Firebase C++ SDK version: 10.3.0
  • Main Firebase Components in concern: remote_config
  • Other Firebase Components in use: auth
  • Platform you are using the C++ SDK on: windows
  • Platform you are targeting: windows

[REQUIRED] Please describe the question here:

hi, I found some crash on my customer's PC, from the minidump, the crash is like this: image the rdx is zero image

and the correspond code is image the rbx+68h get the builder_ the rax+170h use the builder_ get the buffer pointer, the crash reason is GetRoot function will try use the buffer pointer from builder_, but if the buffer pointer is null, it will crash, so I think it should do some protect like this: image

feixuwu avatar Jun 10 '23 15:06 feixuwu

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

google-oss-bot avatar Jun 10 '23 15:06 google-oss-bot

Thank you for reporting this issue.

It is really odd that builder.GetBufferPointer() can return a null pointer. I'll mark this as a bug for now.

chkuang-g avatar Jun 13 '23 20:06 chkuang-g

We’re seeing what looks like the same crash (in remote_config_response.cc:98). I’ve reported the details in #1433.

triplef avatar Aug 25 '23 20:08 triplef

@chkuang-g do you have any update on this? We are seeing many users running into this on app launch when we initialize remote config. We collected all details in #1433, from what it looks like a thread safety issue.

triplef avatar Nov 06 '23 20:11 triplef