Trey Griffith

Results 11 comments of Trey Griffith

Thanks for adding this! Would you mind writing a test for it?

I looked into this a little bit, and I think I know the cause of the issue (although not the solution). `Overlay` is listening for `onClick` events from the `Box`...

> can we test the unhappy path too? I would love to have to a good story around preventing poorly behaving plugins from completely breaking ui-box. Did you have anything...

@mshwery I added some handling for plugins that don't return something that at least looks like what we expect. In production, it skips the plugin and moves on. In all...

@mshwery any further thoughts on this PR?

I guess they just don't give out the API token anymore (not anywhere that I could find), which means I can't use it if I haven't already started. Too bad.

This would definitely be useful. The current implementation breaks when you mangle constructor names, e.g. with Uglify. What are you concerned with it breaking?

@dcousens yeah I see that now. The way to introduce this might be through a new method (shame since the method name `quacksLike` is so good!). Thanks for the note...

@dcousens If you're open to PRs, I can take a first pass at this.

Ok, I'm thinking through this a bit more, and I want to get your opinion before I proceed. It seems the main use of this function is to determine whether...