Trevor Campbell

Results 39 comments of Trevor Campbell

~~I see a bunch of the tests failing because the PyYAML package isn't installed. We included it in the `requirements.txt` file, but I'm sure that's the wrong place to put...

Tests pass on all ubuntu images now. There is a failure on the windows images, though, that occurs at test teardown. I'm not entirely sure what is causing the error....

OK @jhamrick the PR is now officially ready for review. All tests (old and new) pass on all ubuntu images. There is still [one issue](https://github.com/jupyter/nbgrader/pull/1650#issuecomment-1200106958) with test teardown on windows...

@jhamrick we've handled all of your comments now. Should be ready for you again! One question did come up. Running `python tasks.py docs` generated some extra files, not sure if...

Just adding a +1 to this -- I ran in to this exact issue in my course just now!

Hi @jhamrick -- it's been a few months now, and the PR has fallen behind the main branch a bit. This will need a bit of cleanup to get ready...

This PR is superceded by #1817 . We can close this one I think (hopefully the milestone tag can be transferred over to the new PR).

After #1817 was merged this PR is no longer needed. Closing!

`nbextensions` is gone now as of 0.9.x . So this one will need to be revised. But I think JLab comes with a configurable max cell height property / scrollable...

@brichet Yes -- I think we would need to re-do it from scratch anyway now with the new JLab