David Feuer

Results 993 comments of David Feuer

Indeed, it's likely somewhat helpful to know the final tree shape in advance.

This is most impressive. I will do my best to review it promptly. In the mean time, I have a big favor to ask: I was struggling the other day...

I doubt the comparison costs significantly over the test, but benchmarking is the way to know for sure.

I'm ready to merge, but I want to make sure the introduction of the helpers in your last commit didn't hurt performance. Did you check the performance effect of that,...

Why would you set `-A32m` here? That seems to change what the benchmarks are measuring quite a lot. The alignment thing seems reasonable, although it's unfortunate we have to do...

Let's wait with that one for now. I'd like to hear opinions from others on a separate PR.

Aaaaand we're merged! Fantastic work!

I believe the essential problem is that it's impossible to ever `consume` an infinite list. So `cycle` seems quite useless in a linear context. Solution: get rid of it, and...

I'm reopening because I think we should remove `cycle`.

I think the same is true of `repeat`.