Trask Stalnaker
Trask Stalnaker
Follow-up to @laurit's https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/15836#discussion_r2685242443
Produced from working with copilot: # Javadoc Review and Suggestions **Goal:** Improve consistency, clarity, and reduce verbosity while maintaining essential information --- ## Overview This review covers javadoc for all...
I think `wrap` has evolved as our method name for wrapping an instance (e.g. in JdbcTelemetry) Related to - #12846
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/db/database-spans.md#sanitization-of-dbquerytext TODO add opt-in to sanitize anyways?
Consider changing "instrumentation name" from `-` to `_`, due to representation in declarative configuration: ``` instrumentation/development: java: apache_httpclient: enabled: false ``` Also consider changing scope name. From @zeitlinger's https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/15698#discussion_r2637425017
See https://github.com/open-telemetry/semantic-conventions/pull/3097 We could either do this under opt-in flag, or just wait and do straight breaking change in 3.0.
Comment says: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/9e8323ad9355408fb848eca575b21fa95635417c/instrumentation/servlet/servlet-common/library/src/main/java/io/opentelemetry/instrumentation/servlet/internal/ServletRequestParametersExtractor.java#L75-L77 but headers are case insensitive, while request parameter are not, so we shouldn't be normalizing these. This is currently behind experimental configuration `otel.instrumentation.servlet.experimental.capture-request-parameters`, so ok to change...
Now that we have a real configuration API, let's consolidate! This PR shows end-to-end that we can delete all of the other configuration APIs and bridges. `ConfigProperties` still needs to...