Trask Stalnaker

Results 1262 comments of Trask Stalnaker

I like "drop" over "discard" because it aligns with metric view terminology: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#drop-aggregation I think I like "dropNegativeValues" overall, but curious what others think

> Let me know when you want me to give this a proper review I think it's ready for a basic review of the proposed API surface. I'll move it...

> I sure would like a convenience method that (I think) takes a name and some attributes, and skips the builder. `logger.emit("paymentReceived", Attributes.of("amount", 3.14, "currency", "Dollars"))` > > Or however...

> I feel like we might be getting the cart ahead of the horse a bit, if we're not even sure (as a community) that we know how people are...

Closing in favor of #7012 See https://github.com/open-telemetry/opentelemetry-specification/issues/4357 to track the future of an ergonomic event API

let's hold this until after 1.16.0, so we can sort out #6310 first

> we are using makeCurrent() to set the value in the context and this method is itself responsible of closing the scope makeCurrent() isn't responsible for closing the scope maybe...

hi @abhikt48! Mule is difficult for us to test and support. Have you tested this with the upstream OpenTelemetry Java agent to see if the same issue exists? If so,...

hi @asos-radhikajoshi, we have limited ability to understand what could be happening here since the issue only occurs when running in Mule. Have you tested this with the upstream OpenTelemetry...

This is unblocked by https://github.com/open-telemetry/opentelemetry-java-instrumentation/pull/12489 which will be included in this month's Application Insights Java release (we were under end of year critical change only advisory the past two months)...