Giorgio Pellero
Giorgio Pellero
Just as a reminder, the development on this repo has ceased. I've decided that I prefer to not stick with C# for this kind of programs and leverage the already-existing...
Oops, my bad - missed those. Thanks for the help!
@dnwe shall I close https://github.com/IBM/sarama/pull/3158 and move forward with this one instead? If so I'll add a few tests to cover the changes
Hey @dnwe, sorry for the delay, couldn't find time for this until now. After spending some more time learning the lib's structure I ended up addressing your suggestions and making...
@puellanivis thanks for the review! I'd love to run the CI on it to see if there's anything I've missed.
Hey @dnwe! Of course, I'm happy to make wider changes 🙂 Yours seems like a really nice idea. It should be easy to then add the method to every other...
@dnwe yeah, makes sense 🙂 I'll share a link to another draft PR here soon.
@dnwe for now I've opened a draft and copypasted your snipped practically verbatim to all request/response types: https://github.com/IBM/sarama/pull/3170
Hey @dnwe, sorry for the delay 🙂 I've just pushed a commit to https://github.com/IBM/sarama/pull/3170 applying the change you requested to both Request and Response types - I'm not super familiar...