Philipp Grosswiler

Results 19 comments of Philipp Grosswiler

+1 I would also check for `datetime.time` so we have all possible cases of a datetime covered with Pendulum.

@robingenz Have you made any progress on this one already? If not, I would like to help you out with the implementation.

@robingenz Have you made any progress on this one already? If not, I would like to help you out with the implementation.

> @trancee No, there is no progress yet. You are very welcome to contribute! If you have any questions, let me know. Feel free to let me look at the...

@robingenz What's the idea behind `linkWithGoogle` or `linkWithXXX`? I know there is a method called `linkWithCredential` but it requires a `AuthCredential` from Firebase which we do not have. Did you...

@robingenz There are 3 ways to linking: - `linkWithCredential` - `linkWithPopup` - `linkWithRedirect` We are mainly using `linkWithPopup` and not `linkWithRedirect`. Or should there be an option to use either...

> Good idea! But i suggest to call it `SignInProvider` (better fits to the config option `providers`) and to not export it (or is this necessary?). You can also remove...

I have added the `linkWithProvider` method to simplify the usage of different providers. This is just a suggestion, it would remove a lot of code duplication for basically the same...

> To be honest, I don't like that approach for 3 reasons: > > 1. I prefer several smaller methods than one big method, even if you have less duplicate...

If the definitions are fine with you, I will start with the implementation.