traincheck-team
traincheck-team
@microsoft-github-policy-service agree
This fix still has interference with existing unit tests. Let me double check before we proceed.
The unit tests in `tests/unit/runtime/test_ds_initialize.py` all passed. The PR is ready for review @tjruwase. I am not able to check other unit tests due to GPU memory constraint.
Thanks for the review @tjruwase. - I added handling for callable types for optimizer and lr_scheduler. The handling is to only mark `is_ds_inited` for objects instead of callables, as the...
Got it. Yeah 3 is technically what should be implemented instead of letting flags just flying around. Will get the update EOD.
@tjruwase Thanks for the suggestion. Please check the updated PR.
@tjruwase Hi Olatunji, are there any further modifications that you'd like me to do?
@loadams Thanks for getting back so quickly and I apologize for the late reply. I inspected the 9 tests that failed. It appears to me that these tests failed because...
Thanks for the heads up. Will do that soon. On Fri, Jan 31, 2025 at 15:03 Logan Adams ***@***.***> wrote: > FYI @traincheck-team - there still > appear to be...
@loadams I tried to amend the six problematic commits using git rebase, but since there were previous merges from main into this branch, it caused conflicts and made things messy...