tpw56j

@SchoolGuy > @tpw56j Do you know why you put the `if` statements around the bootloaders? I tracked this down to you in the following manner: Menu generation logic for ipxe...

@SchoolGuy Grub, in turn, differs from pxe and ipxe in that not one menu file is generated, but one for each Arch.

@SchoolGuy I don't know why generate a grub menu for each platform, since only one can always be present in a distro or image. The code for grub was not...

@SchoolGuy If we remove this `if`, then we will get an exception on the next line with an empty menu.

@SchoolGuy I think it's better to check for an empty menu and generate the menu outside of that `if`.

@SchoolGuy `loader_metadata["menu_items"] = menu_items.get("pxe", "")` - this code should not throw an exception even without `if`. It seems to me that this PR is the correct fix for my code.

@SchoolGuy I also suggest (possibly in a new PR) move the contents of `cobbler/config/grub` to `cobbler/templates/boot_loader_conf/grub_menu.template` and remove the Archs loop to generate the grub menu. Then the menu for...

@SchoolGuy Previous PRs have made support for installing Windows via PXE and iPXE without using SSCM. Much of what SSCM does can be done through cobbler templates for windows in...

Why not just tweak the `/etc/cobbler/boot_loader_conf/{pxe|ipxe|grub}.template`? For example my `pxe.template`: ````diff @@ -23,6 +23,14 @@ localboot -1 #else kernel $kernel_path +#if $breed == "redhat" +#if $os_version == "rhel6" +#set $append_line=$append_line.replace("inst.",...

Sorry, transferring complexity and opacity from code to templates was not a good idea. Maybe move the boot line options to `distro_signatures.json` and completely clean up the code and templates...