Ted Pudlik

Results 42 comments of Ted Pudlik

Yeah, that's right. I just wanted to report that this user journey is a bit awkward for me. But I understand it may not be easy to smooth out!

Warnings must be actionable: you must be able to do _something_ to make the warning go away (either fix the root cause, or explicitly silence the warning). Otherwise, warning spam...

This is awesome! We build our documentation (https://pigweed.dev) using Sphinx, and we've long talked about doing it using Bazel, but felt a little overwhelmed. Looks like we should take a...

@comius for the `rules_cc` perspective, @katre since it's (at least) Configurability-adjacent.

http://pwrev.dev/221453 is the publicly available link to the CL Taylor mentioned. I do think we should consider upstreaming to `rules_cc` the `//pw_toolchain/cc:cxx_standard` `string_flag` and the associated `config_setting`s, and maybe even...

I used to think this would be quite easy: https://github.com/tpudlik/rules_cc_toolchain/commit/80677f37da51d3d18cc9baba63327d36d91b23bd But to my surprise, this leads to errors when I try to compile Pigweed. Typical error: ``` In file included...

This would be very helpful to us on the Pigweed side, as it would allow us to bring the toolchains we use in gn and bazel in line (https://bugs.chromium.org/p/pigweed/issues/detail?id=637).

Although this is described in https://github.com/aspect-build/rules_js/issues/1408#issuecomment-2045767314 as "mostly" mitigated, we still get tens of warnings like, ``` input 'package' of //:.aspect_rules_js/node_modules/@[email protected]/lc is a directory; dependency checking of directories is unsound...

This remains an important gap in the documentation, and should remain an open issue.

See also https://issues.pigweed.dev/issues/360950550#comment3 for more (maybe too much!) context.