Tomasz Poradowski

Results 60 comments of Tomasz Poradowski

@tianon: Yes, unfortunately that port to Windows is no longer maintained, so I've spent some time and I'm trying to update it to latest Redis 4.0.2. [This is my fork...

I would not mind at all if the fork I'm maintaining would be listed on the downloads page :). There are still a couple of pending issues related to RDB...

Yes, that function relies on [WSAStringToAddressA](https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-wsastringtoaddressa) which handles only string representations of IPv4 and IPv6 addresses. You can therefore also use "::1" for IPv6 equivalent of localhost. In original Redis...

@mrniko could you please provide a test case? I've tried the following: ``` 127.0.0.1:6379> BRPOPLPUSH issue94 issue94_dest 500 "value1" (15.73s) 127.0.0.1:6379> BRPOPLPUSH issue94 issue94_dest 5 (nil) (5.07s) 127.0.0.1:6379> BRPOPLPUSH issue94...

Can you provide log file or any details why saving of RDB failed? Were you using any previous version and it worked before, but now it does not?

Thanks @paviad for your detailed report - it seems like an overflow issue, I will investigate that soon.

You mentioned 2-3GB dataset, is there anything specific about that data? (very long values, mostly values of one particular type - if so which one?). Could you please provide output...

Yes, it shows maximum memory amount that was allocated for input data within like last 8 seconds, if you are curious here is the description how it is tracked: https://github.com/tporadowski/redis/blob/develop/src/server.c#L907-L919

Yes, thanks for additional details - yesterday I had some time to play around with and wrote a small tool to simulate some workload like yours - and got similar...

Yes, RDB/AOF are saved in forked process. While testing this I also observed some staleness between fork completes its job and result is returned to parent, so another place to...