Tim Pope
Tim Pope
> As described above, having just paths and line numbers for both sides is not enough to unambiguously define position in a diff for all providers. We also need the...
It's very much still on the agenda. It's prioritized below other Fugitive changes I've been banging my head against. This particular PR is too heavy and consequential to consider jumping...
Is this sufficient? ``` { "path": "new_path.txt", "line1": 5, "line2": 10, "diff": { "path": "old_path.txt", "line1": 4, "line2": 0, } } ``` Instead of `cursor` or `sigil` fields, send a...
To be clear, we don't actually want to do anything with that second filename, correct? We just want to avoid pretending that second file's line number belongs to the first.
Now that I think about it, a better key name than `diff` would be `ancestor`. That way there's zero ambiguity with any future compare view between 2 arbitrary commits. Either...
I think we should probably match `git log --oneline`, with the decorations up front in parentheses. I think starting a commit message with a parenthetical is suitably weird that we...
Poking around in some histories I occasionally see messages starting with `(Hopefully) fix` or `(trivial)`. I don't have a solution, but I would be inclined to explore using syntax concealing...
> The thing I am worried about is that because I have added the concealed text, when using `h` or `l` to move horizontally in the line, those characters are...
> I've added a separate parameter to avoid hacks with splitting the `a:refspec` by `..`. I've also added hiding `HEAD`. `origin/HEAD` can be hidden if we have a list of...
> After a few minutes of testing, looks like `--decorate-refs-exclude` is essentially what I have implemented as part of this PR, but it requires adding additional stars (or prefixing the...