Thomas O'Dowd

Results 69 comments of Thomas O'Dowd

Hi @ktdreyer - I'll look into this early November. It's on my todo now. I've no time currently. Will let you know when I'm done.

Hi @wader - sorry I've been traveling. Finally back. I don't actually use the multiline input in my use case. Not sure exactly what you mean by the prompt will...

Hi @wader - I see. I'm currently working on other projects not related to readline which will keep me busy for a while. Since this is unrelated to this PR,...

Hi @slingamn - Thanks for reporting that. I'm a little swamped right now, but I'll try look at that this week. I was able to replicate by running. ``` go...

Hi @slingamn - Have not had a lot of time yet. Still high on my list. I did do some review though. the race condition above is a simple fix....

Note: I rebased this PR on the latest master and also added a small commit that fixes the race condition mentioned above that this PR introduced. I am also going...

Hi @slingamn. Just had a look at this. I think the patch to remove the IsReading check is probably not the right fix particularly combined with this PR. So what...

Cool. Thanks for the feedback. I'll see what I can do.

Hi @slingamn I pushed another commit to this PR. I believe that this addresses your issues. I removed the race condition with the prompt redraw. I removed the terminal isReading...

Hi @slingamn - I tested this branch also on a windows VM this morning. Looks good to me. I tested all the examples as well as your test program in...