Tomasz Pasternak

Results 99 comments of Tomasz Pasternak

Ok, LGTM @mai93 @jastice we don't have integration tests for this, but it seems we can't develop them due to limitations of current tests framework. Can we merge this?

Hey @maxlepikhin which version of bazel and rules_python you use? I just tried to set it up, but it fails on this line (there's no field native.bazel_version) https://github.com/bazelbuild/rules_python/blob/e0a78297164ad8eacabc965111ff19d4e4144786/third_party/github.com/bazelbuild/bazel-skylib/lib/versions.bzl#L91 ---- BTW...

Oh, so do you mean pip_parse or pip_install?

Hey, I'm only wondering what are the implications of passing empty `compilerClasspath` to `ScalaLibraryProperties`

I think it could affect places where Scala Remote Server is spawned, for example expression evaluator @jastice

Hey Kamil, could you share an example showing the issue?

> However, if the provider then adds the folder as a test source anyway And when can this happen?

The code above is essentially equivalent to the one below. I'm wondering why we don't ` contentEntry.removeSourceFolder(parent)` here. Apart from this, I guess you have some custom provider which sets...