intellij icon indicating copy to clipboard operation
intellij copied to clipboard

Include implicit dependencies from proto compilers

Open fkorotkov opened this issue 3 years ago • 12 comments

Checklist

  • [x] I have filed an issue about this change and discussed potential changes with the maintainers.
  • [x] I have received the approval from the maintainers to make this change.
  • [x] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Description of this change

go_proto_library has compilers which bring some types implicitly. Let's not forget to include them.

fkorotkov avatar Feb 11 '22 21:02 fkorotkov

Here are the compilers in question from rules_go.

fkorotkov avatar Feb 11 '22 21:02 fkorotkov

@alice-ks gentle ping

fkorotkov avatar Mar 23 '22 01:03 fkorotkov

@alice-ks 2022.1 is in beta now. I think it might be a good time to merge some changes to intellij_info_impl.bzl. Could you please take a look?

fkorotkov avatar Apr 15 '22 01:04 fkorotkov

LGTM

tpasternak avatar Aug 10 '22 09:08 tpasternak

Hello @fkorotkov, Could you please update the PR description with the relevant issue or feature enhancement. Thanks!

sgowroji avatar Sep 13 '22 06:09 sgowroji

@sgowroji please check "Description of this change" that I had and let me know if it needs more details.

fkorotkov avatar Sep 13 '22 11:09 fkorotkov

@fkorotkov Thank you for replying, Is there a way we could test the above PR changes fixing the issue.

sgowroji avatar Sep 15 '22 10:09 sgowroji

I didn't see any tests for other DEPS back 7 months ago when I opened the PR. Now I have other things on my plate and don't have time in the near future to work on adding such tests. Closing the PR until then.

fkorotkov avatar Sep 15 '22 11:09 fkorotkov

I think the query was as to how we can verify it, not to add specific tests. Was that the intention, @sgowroji ?

jastice avatar Sep 15 '22 11:09 jastice

Yes @jastice. Wanted to verify the PR changes.

sgowroji avatar Sep 15 '22 12:09 sgowroji

I'll reopen this then, can you just give us a hint what behavior change to expect, @fkorotkov ? Thanks!

jastice avatar Sep 20 '22 09:09 jastice

My bad with the initial description which doesn't clarify "some types" but I guess there sources is what I meant. If I recall correctly there were some issue with the plugin not being able to resolve some well known types.

fkorotkov avatar Sep 20 '22 12:09 fkorotkov