intellij
intellij copied to clipboard
Include implicit dependencies from proto compilers
Checklist
- [x] I have filed an issue about this change and discussed potential changes with the maintainers.
- [x] I have received the approval from the maintainers to make this change.
- [x] This is not a stylistic, refactoring, or cleanup change.
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.
Description of this change
go_proto_library
has compilers which bring some types implicitly. Let's not forget to include them.
Here are the compilers
in question from rules_go
.
@alice-ks gentle ping
@alice-ks 2022.1 is in beta now. I think it might be a good time to merge some changes to intellij_info_impl.bzl
. Could you please take a look?
LGTM
Hello @fkorotkov, Could you please update the PR description with the relevant issue or feature enhancement. Thanks!
@sgowroji please check "Description of this change" that I had and let me know if it needs more details.
@fkorotkov Thank you for replying, Is there a way we could test the above PR changes fixing the issue.
I didn't see any tests for other DEPS
back 7 months ago when I opened the PR. Now I have other things on my plate and don't have time in the near future to work on adding such tests. Closing the PR until then.
I think the query was as to how we can verify it, not to add specific tests. Was that the intention, @sgowroji ?
Yes @jastice. Wanted to verify the PR changes.
I'll reopen this then, can you just give us a hint what behavior change to expect, @fkorotkov ? Thanks!
My bad with the initial description which doesn't clarify "some types" but I guess there sources is what I meant. If I recall correctly there were some issue with the plugin not being able to resolve some well known types.