Toyo Li

Repeated single line comment after variable declaration in if/for block when targeting ES5

1

# Bug Report ### 🔎 Search Terms comment ### 🕗 Version & Regression Information - This changed between versions 4.6.4 and 4.7.4 ### ⏯ Playground Link [Playground link with relevant...

Failed to parse wz on 'staging' branch

1

Client: GMS 231.1 WZ file: Sound.wz, Sound2.wz etc I could open wz file in GUI but could not expand it... While master branch is all ok   Failed to...

#15 No breaking change. `includeBaseDirectory` is `false` by default.

Incorrect integrity of transformed files?

2

https://github.com/electron/asar/blob/c2b4777a4089d19b12327888577e2ffec1cc1dae/lib/filesystem.js#L70-L94 https://github.com/electron/asar/blob/c2b4777a4089d19b12327888577e2ffec1cc1dae/lib/filesystem.js#L94 `p` is original file path, while transformed file path is https://github.com/electron/asar/blob/c2b4777a4089d19b12327888577e2ffec1cc1dae/lib/filesystem.js#L73

Support `rebuild` and `build` when configure with `-- -f make` on Windows

3

##### Checklist - [x] `npm install && npm run lint && npm test` passes - [x] commit message follows [commit guidelines](https://github.com/googleapis/release-please#how-should-i-write-my-commits) ##### Description of change `node-gyp rebuild` and `node-gyp build`...

Question about cross compile Node-API addon to wasm with emnapi and emscripten on Windows/macOS

13

Hi! I'm the creator of [emnapi](https://github.com/toyobayashi/emnapi) which is a Node-API implementation for emscripten/wasi-sdk, it can be used for porting existing Node-API native addon to WebAssembly. I'm wondering if node-gyp can...

Would you mind switch to use `deno_std`'s path module? API is compatible with Node.js, simply use `deno bundle` to output es module, make bundlers do tree shaking better ```ts //...

How about add C++20 coroutine support to `Napi::Value`?

6

embind already has coroutine implementation https://github.com/emscripten-core/emscripten/blob/b5b7fedda835bdf8f172a700726109a4a3899909/system/include/emscripten/val.h#L703-L789 I just now tried to write a toy version, that makes it possible to `co_await` a JavaScript Promise in C++. class CoPromise : public...

feat: add new option to allow waiting thread start before thread-spawn return

1

https://github.com/WebAssembly/wasi-threads?tab=readme-ov-file#design-choice-pthreads > 4. in pthread_create, call wasi_thread_spawn with the configured start_args and use atomic.wait to wait for the start_args->thread->tid value to change (note that for web polyfills this may not...

emnapi WebAssembly build

2

I created [emnapi](https://github.com/toyobayashi/emnapi) for porting Node.js addons written in Node-API to Emscripten WebAssembly. I successfully built this project to wasm, all test cases passed ~~except the one related to `async_hooks`,...