Anton Artemov
Anton Artemov
> I found a couple of places to realign the parameters, but otherwise this looks good. I like the new naming conventions. We have a lot of handshakes now! Were...
/integrate
> I couldn't spot these - do you have a link please? It is annoying this prevents use of `ssize_t`. In osContainer_linux.hpp there is `OSCONTAINER_ERROR` defined with value -2. This...
@tstuefe do you have any suggestions?
@stefank I inspected the container-related code once again, and came to conclusion that it is safe to use ssize_t, as you suggested above initially. The `OSCONTAINER_ERROR` return value will not...
> Hmm. Maybe I'm reading this wrong, but to me it looks like you can return -2 via this code: Yes, you are correct that **that** code can return -2...
I think we could extend the usage of a large number `static_cast(-1)` for indication of error to other platforms similarly to how it is done in `os_linux.cpp`.
> I prefer the dedicated struct approach, as it > provides meaningful names. I now refactored the code to return a struct instead. > This may have been more effort...
> FWIW, I think that the `ssize_t` was a good first step and the `MemRes` was an experiment that would be interesting to see if how that panned out, but...
> About the MemRes change. I think adding the MemRes instance and then initializing it later makes the code messier: I generally agree that it is more convenient to construct...