Tor Harald Sandve comments

Results 368 comments of


                                            Tor Harald Sandve

ML keras

jenkins build this please

ML keras

jenkins build this please

ML keras

jenkins build this please

For convective mixing, store the saturated dissolution factor.

Make sense to put rssat in the intensiveQuantities rather than the fluidstate. So I will close my PRs. I my PRs I changed default enableConvectiveMixing to false and only activated...

For convective mixing, store the saturated dissolution factor.

Thanks. I am happy and Jenkins is happy. Will merge.

DRSDTCON: behavior changes and poor performance in 2024_10

Between 2024.04 and 2024.10 we did large changes in how DRSDTCON is implemented. The new implementation improves the accuracy of the model. We are in the process of updating the...

DRSDTCON: behavior changes and poor performance in 2024_10

The main reason for the slowdown is that the new code is not optimized and therefore computes the phase partitioning many times per iteration. I already have code that address...

DRSDTCON: behavior changes and poor performance in 2024_10

The speedup was finally merged into master and should be ready for the upcoming release.

Throw for complex std::pow results in CO2::vaporPressure

The safeguard added here is fine. I will add a fix that make sure it never is thrown. I suggest we merge that fix first.

Throw for complex std::pow results in CO2::vaporPressure

jenkins build this please