opm-simulators icon indicating copy to clipboard operation
opm-simulators copied to clipboard
verified publisher icon OPM

For convective mixing, store the saturated dissolution factor.

Open atgeirr opened this issue 1 year ago • 4 comments

Gives a significant speedup with DRSDTCON.

Same idea as OPM/opm-common#4364 and #5771, but with some differences. I managed to avoid noticing that one, or I would not have made this...

atgeirr avatar Nov 29 '24 13:11 atgeirr

jenkins build this please

atgeirr avatar Nov 29 '24 13:11 atgeirr

new file is missing from CMakeLists_files.cmake. EDIT: never mind, it's not a new file.

akva2 avatar Nov 29 '24 14:11 akva2

Make sense to put rssat in the intensiveQuantities rather than the fluidstate. So I will close my PRs. I my PRs I changed default enableConvectiveMixing to false and only activated it for gas+water+dissolution and gas+oil and it's thermal/diffusion variants. Does it make sense to do something like this in the PR as well?

totto82 avatar Dec 02 '24 07:12 totto82

@atgeirr : Is there any more work coming here?

bska avatar Dec 19 '24 10:12 bska

This was forgotten, but I will rebase and revive it!

atgeirr avatar Apr 01 '25 10:04 atgeirr

Rebased, and I have no further work to add.

atgeirr avatar Apr 01 '25 11:04 atgeirr

jenkins build this please

atgeirr avatar Apr 01 '25 11:04 atgeirr

jenkins build this please

atgeirr avatar Apr 03 '25 08:04 atgeirr

Thanks. I am happy and Jenkins is happy. Will merge.

totto82 avatar Apr 03 '25 09:04 totto82