Tóth András

@SimonHeimberg I took over from your suggestions what I agree with. Thank you for them, some of them were major improvements. Sorry about the rest.

I believe the latest failures are due to a regression in master. Most likely introduced by #6153, because the failures only happen in the template tests and that has been...

> I believe the latest failures are due to a regression in master. Most likely introduced by #6153 I was completely wrong. The failures started after the naval warfare merge,...

> `LuaPlayer::message_box` (and any other lua functions that use `NoteThreadSafeFunction::instantiate` too) Good news(?), message box is the only one.

> I don't know if it's possible, but I think `LuaPlayer::message_box` (and any other lua functions that use `NoteThreadSafeFunction::instantiate` too) should make their coroutine yield, release locks for the duration...

> I tried to test it but loading any of my existing naval warfare saves with [95e2a81](https://github.com/widelands/widelands/commit/95e2a81947332f4fb81d44a9344bacf27ce0227f) results in an `std::bad_cast`. The same saves load fine with [dde0280](https://github.com/widelands/widelands/commit/dde0280a24e6a3fdd58edee75439600b45c032f5). Do you...

Hmmm, https://en.cppreference.com/w/cpp/types/bad_cast says: "An exception of this type is thrown … also from [std::use_facet](https://en.cppreference.com/w/cpp/locale/use_facet) if the requested facet does not exist in the locale."

@Noordfrees I think https://github.com/widelands/widelands/pull/6146/commits/e499df01684afc7b887a43158fdf241021baaf4b corrects an overlook in my refactoring that involves locales and looks suspiciously plausible that it may have caused the `std::bad_cast` for you but not for me....

> * Please add a whitespace between the symbol and the warehouse's name Done. > * IMHO we shouldn't show this for warehouses that can't have a garrison setting and...

> I though about this some more and actually I think not only should we not show it for warehouses, it also should not be shown for ports and HQs...