Toshiki Kataoka
Toshiki Kataoka
`size=None` is different from `size=()`. ``` >>> np.random.uniform([2], [[3]]) array([[2.63150331]]) >>> np.random.uniform([2], [[3]], size=()) Traceback (most recent call last): File "", line 1, in File "mtrand.pyx", line 1317, in mtrand.RandomState.uniform...
The PCL implementation causes a minor error when it is used with step_offset, because of ```python if self.t - self.t_start == self.t_max: ``` in pcl.py, while self.t is overwritten by...
Some agents e.g. `chainerrl.agents.DQN` store a `state` argument of `act_and_train` without copying. This implementation doesn't always work well, e.g. if `env.step` constantly returns an array like `env._state` that has a...
For example, the following test is wrong because it just checks `TypeError` is raised for some dtype. ```python # wrong order of decorators @testing.numpy_cupy_allclose(..., accept_error=TypeError) @testing.for_dtypes(...) def test_neg(self, xp, dtype):...
Please review ~#5953 and~ #5964 first. ~This also fixes #4486.~
- maintain `readonly` flag of the current array `a`. The flag is turned off after a copy or a non-overwriting step. - `ascontiguousarray` is moved from `_fftn` to `_exec_fftn` for...
Because s3fs (fsspec) supports some glob patterns (`*`, `**`, `?`, and some of `[]`), there are file names that should not be passed to `self.fs.cp` or `self.fs.rm` without escape. ###...
Fix #131. Fix `shared-data` config to align with `dest` in `_jupyter_labextension_paths`. Fixing `dest` instead doesn't work. Maybe it's an issue of ipywidgets or jupyterlab, because https://jupyterlab.readthedocs.io/en/latest/extension/extension_dev.html#distributing-prebuilt-extensions says "typically", not "exactly"...
https://github.com/jupyter-widgets/widget-ts-cookiecutter/issues/131#issuecomment-1517610319
Even if we want to ensure that there's no tracked-but-ignored file, I suggest ```diff -docs/source/_static/embed-bundle.js -docs/source/_static/embed-bundle.js.map +docs/source/_static/* +!docs/source/_static/helper.js ``` and ```diff -{{ cookiecutter.python_package_name }}/nbextension/index.* +{{ cookiecutter.python_package_name }}nbextension/* +!{{ cookiecutter.python_package_name }}/nbextension/extension.js...