crayon icon indicating copy to clipboard operation
crayon copied to clipboard

Empty experiments are not listed properly

Open albanD opened this issue 8 years ago • 6 comments

Empty (with no point) experiments are not listed in the GET /data endpoint properly here. Even though it properly raises an error when trying to create a new one with the same name and opening it works as expected.

albanD avatar Feb 14 '17 14:02 albanD

I'll do this when I refactor the server post-ICML.

edran avatar Feb 14 '17 14:02 edran

I think this is the same issue I am, having, to make things more concrete, you can see the issue I have here: I get this error: ValueError: Something went wrong. Server sent: 'scalev7' experiment already exists. `

cc = CrayonClient(hostname="localhost")
print(cc.get_experiment_names())
if args.name in cc.get_experiment_names():
    cc.remove_experiment(args.name)
cc_server = cc.create_experiment(args.name)`

here is the output of get_experiment_names: ['scalev3', 'scalev5', 'scalev4']

jtoy avatar Jun 17 '17 15:06 jtoy

Come across the same bug. It seems that cc.get_experiment_names and cc.remove_all_experiments don't function well.

ytian81 avatar Jun 22 '17 01:06 ytian81

And those are the main functions of this library!

On Jun 21, 2017, at 6:57 PM, Yang Tian [email protected] wrote:

Come across the same bug. It seems that cc.get_experiment_names and cc.remove_all_experiments don't function well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

jtoy avatar Jun 22 '17 16:06 jtoy

I think these lines are the ones involved in the issue: https://github.com/torrvision/crayon/blob/master/server/server.py#L252-L256

remove_all_experiments tries to get_experiment_names but the function retrieves only experiments which have data. This seems like incorrect logic to me, we would like to return all experiments, no matter if they have data associated or not.

Timonzimm avatar Aug 16 '17 16:08 Timonzimm

Bumping this up. Experiment with zero data points doesnt get listed in get_experiment_names(), but still exists on the server. Removing and creating seems to be the go. For now.

IMG-PRCSNG avatar Sep 29 '17 07:09 IMG-PRCSNG