TÖRÖK Attila

Results 503 comments of TÖRÖK Attila

Oh, it must be because it's an `http://` URL... 🤦‍♂️ It's not the best UX if you ask me... https://support.google.com/chrome/thread/77421860/clicking-download-link-does-nothing-at-all?hl=en Let me fix it quick!

> This removes the dependency on `core` from every render backend crate, which speeds up compiling by allowing them to be done in parallel to core. Yay! > `types` suggests...

I don't understand this part of the commit message: ``` However, note that the `Matrix` and `ColorTransform` valuse *produced* the getter are plain ActionScript objects, and have no further tie...

And this is just a nit, but I think this line: `a scale matrix that the depends on the global state quality.` Should be changed to: `a scale matrix that...

Furthermore, maybe this could be split into (at least) three separate commits? One adding the implementations, one extending the test framework, and one adding the tests. That could also cut...

I'm a bit late, and thanks for the explanation @Aaron1011; what I meant is that, that sentence didn't immediately make sense to me grammatically. Perhaps there is a missing "by"...

Cc: https://github.com/ruffle-rs/ruffle/pull/7428 (@Aaron1011)

Almost all `.as` files added end with two `^M` characters - which is the Carriage Return AFAIK. They don't cause any harm, just aren't that nice.

A couple of event classes (for example `DeviceRotationEvent`) only have AIR mentioned as a runtime supporting them. I don't think these ones are in the scope of Ruffle (yet)...?

Yeah, they would only be unnecessary noise IMHO. Thanks for checking them @danielhjacobs!