Marcin Torba

Results 27 comments of Marcin Torba

Well, I thinks it's just one setting - when comparing string you can specify if you want to ignore case or not. ```csharp string.Equals(val, "astringvalue", StringComparison.OrdinalIgnoreCase) ``` or ```csharp string.Equals(val,...

Not long ago, I was working with mDNS. I've tried to set up HomeAssitant server with mDNS on board. Everything works just fine from Windows machine, but Android phone was...

Yes, first refactor then new changes.

@josesimoes One more issue, tests are throwing exceptions, yet passing in runner (due to suppression of exceptions) ![image](https://user-images.githubusercontent.com/19893965/183479291-e04e4f14-4418-4ef5-abdd-d17051fdc6e8.png)

Info: There is a script for syncing all projects in path: /StyleCop/syncSettingsOverEveryDevice.ps1 Please use it, if you want apply stylecop to project.

@rkalwak Unfortunately it does not support some C# features and the analysis stops when meets this kind of code. As for workaround I suggest to replace `if (value.DegreesCelsius is <...

I think the best approach to work on style cop fixes is: 1. Replace in syncSettingsOverEveryDevice.ps1 script `$projectWhiteList = ("AD5328", "4Relay", "Ads1115", "Adxl345", "Adxl357", "Ags01db", "Ahtxx")` with `$projectWhiteList ` 2....

@Ellerbach Hope you haven't start working on it. I've played a little bit with benchmark tool, just to see how it's working in real example. So I've checked every unit...

@Ellerbach Let me do it :) I'm already working on refactoring JSON lib, I've extracted all type compare to single method, so should be easy to change. Also I'll take...

@josesimoes Reopening, still need JSON part.