Tor Arne Vestbø comments

Results 164 comments of


                                            Tor Arne Vestbø

Add custom boot command that waits for text to appear

This allows e.g: ```diff diff --git a/macos/macos.pkrtpl.yaml b/macos/macos.pkrtpl.yaml index bed5e73..305532e 100644 --- a/macos/macos.pkrtpl.yaml +++ b/macos/macos.pkrtpl.yaml @@ -1,14 +1,8 @@ -wait_for_boot: - # Wait for VM too boot - # FIXME:...

Add custom boot command that waits for text to appear

Is the builder not a macOS machine?

Add custom boot command that waits for text to appear

Thanks @edigaryev! I did initially considered building this feature into [packer-plugin-sdk](https://github.com/hashicorp/packer-plugin-sdk)'s `bootcommand` package directly, but as this was a quick hackathon project, where my focus was to get something workable...

Add custom boot command that waits for text to appear

I guess we need to move the lint and build to a `macos_instance`? Are there any predefined Cirrus images or rules that include the golang (lint) toolchain?

Add custom boot command that waits for text to appear

> Missing docs for new wait command, will add after initial feature review Done

Add custom boot command that waits for text to appear

@edigaryev @fkorotkov thoughts? 🙂

Add custom boot command that waits for text to appear

Thanks for the reviews @edigaryev, will push an update soon. And thanks for fixing the CI bits to run on macOS :)

Add custom boot command that waits for text to appear

Hey hey @hisaac! I've been swamped, but picking this up now, will push a new PR soon!

Add custom boot command that waits for text to appear

@hisaac Please test the latest version, thanks! 😄

Add custom boot command that waits for text to appear

@hisaac @edigaryev you may find https://github.com/hashicorp/packer-plugin-sdk/pull/293 convenient as well. If it takes time to merge upstream, perhaps we can `go replace` the SDK with my fork?