Toran Billups

Results 57 comments of Toran Billups

Okay I've got this rebased - still needs some docs love (copy/paste of what Thomas linked us to above). I need to see how this looks/feels in a real app...

@bstro The only real blocker at the moment is my internal debate over the "breaking change" this introduced. The problem is that previously we wouldn't include a reducer for you...

@bstro It's possible we could land this in 2x -worth a debate on the "breaking change" I mentioned above. That said, in the discussion about 3X I showed a graph...

@brettburley it sounds like we agree that this change does not introduce a real/ functional breaking change of any kind. @brettburley I've updated the name you called out `middlewareConfig` to...

@foxnewsnetwork @brettburley @bstro I threw together a working ember-cli v2.4.3 app using this fork and customized the redux store creation. Looking for feedback on this before we merge it next...

@bstro one issue I've found today is that I can destructure enhancers just fine but not the reducers for some reason. The below doesn't blow up, but the reducers don't...

@bstro I believe the variables we destructure in `makeStoreInstance` reference the "default" imports that ship with `ember-redux` itself (meaning the reducer/middleware/enchancer in this addon .... that do next to nothing)....

@bstro I'm personally good with this myself (just wasn't sure if that was the expectation when I took my first stab at extending it). This does have the added benefit...

@bstro one last look at how we could show this in action. I took a step back and found this worked perfectly (as I import the reducers/enhancers myself and construct...

@bstro @brettburley @foxnewsnetwork this has been released as part of ember-redux v2.10