Matt Mc

Results 149 comments of Matt Mc

I'm more or less in favor, I think the remaining question is which kinds of elements are targeted and whether they have separate flags: - `aside[epub:type="footnote"]` - `aside[epub:type="endnote"]` - `section[epub:type="footnotes"]`...

> If this list might change depending on the app, then I think this should be handled by CSS injection in the Navigator. Out of curiosity, is there a good...

@usernope what is your expected output? `` or some such? If the output is really blank, Algernon's only failing is probably that it does not output `` or `` or...

Ah, so the output contains no instances of the text `test 2:` Interesting. This, or approximately this, was working as of https://github.com/xyproto/algernon/pull/79 so perhaps some kind of regression.

I reproduced with the latest release on Windows. Straight sequences and key-value tables work fine, but nesting a table makes the length zero. Also checked with `{{ object_list | length...

Hey @xyproto I believe the problem is the output should look roughly like this: ``` This is the title test 1: 2 test 1: 3 test 1: 1 test 2:...

Don't object to this, but unfortunately the linting is not happy. Most of the linting issues were fixed with https://github.com/ajvb/kala/pull/257 but that PR has other elements which I had questions...

Heads up, the other PR was merged.

> if this safe way to do conversions exists, then I would also like it if as gets renamed to both better reflect that it doesn't do any checks (and...

The `as!` is cribbed from Swift. (It has `as`, `as?` and `as!` which all behave a little differently.) `transmute!` is rather a mouthful.