Greg Ross

Probably won't help with commits, as while the export order isn't pretty, it should be consistent between exports. I'm fine with setting one, just need to make sure we track...

Given no changes in the database rows, the export will be in the same order as it will pick up the default order (I assume this is row number), so...

Adding an optional original sounds like it would break less things 😉

If any plugin uses the method, changing the parameter list would break them. Where as adding an optional to it would allow them to continue to work.

That would work fine as well, though it would be prone to code duplication, might have to make a private function to do the bulk of the work for both...

@maximejobin you should probably open this up as an issue on the meta trac over a wordpress.org.

I thought updating coding standards for their own sake was frowned upon? I'm not against it though, but a few thoughts: > One pull request should not contain more than...

> > This seems arbitrary at best, perhaps something more along the lines of a logical grouping. > > It's not that arbitrary. Three files can be quickly checked via...

#747 will make formal/informal easier and not require the export/import hack.

> > Directly assign the locals array instead of creating temporary variables > > I don't see the need for that. The temporary variable looks cleaner and is less code....