Tony Trinh

Results 75 comments of Tony Trinh

Thanks for the contribution, @akhikhl. Please add a comment here with release notes (see rule P7 of [CONTRIBUTING.md](https://github.com/qos-ch/logback/blob/master/CONTRIBUTING.md)).

A workaround for now is to replace this line: https://github.com/tony19/logback-android/blob/a7bc9ae7fd4508e9da3f24293b9c73f8bab76f5c/scripts/makejar.sh#L13 with the `VERSION_NAME` variable from `gradle.properties`: https://github.com/tony19/logback-android/blob/a7bc9ae7fd4508e9da3f24293b9c73f8bab76f5c/gradle.properties#L11 The result: ```diff -. gradle.properties +VERSION_NAME=3.0.1-SNAPSHOT ```

Thanks for the contribution, @nrkkalyan. Please add a comment here with release notes (see rule P7 of [CONTRIBUTING.md](https://github.com/qos-ch/logback/blob/master/CONTRIBUTING.md)).

I was actually looking for raw HTML that describes your change, which would be added to the release notes page.

@nrkkalyan, looks like there's a comment you haven't addressed. @ceki, please review this PR.

> Questions: > 1. Should I also extend the documentation with this pull request? > 2. Should I implement some integration test in addition to the supplied unit tests to...

Please squash these commits so that a single clean commit is merged. Also please update the [release notes](https://github.com/qos-ch/logback/blob/master/logback-site/src/site/pages/news.html) to indicate your change, including the JIRA key. Thanks.

Moving the `:key` binding from `` to `` resolves the issue: ```html 👇 ``` [demo](https://stackblitz.com/edit/vue3-forwarding-slots-vant?file=src%2Fcomponents%2FComponentB.vue,src%2FApp.vue)

Your usage in that blitz doesn't make sense to me. To forward the default slot, just use ``: ```html ``` [demo](https://stackblitz.com/edit/vue3-forwarding-slots-pkmvmx?file=src%2Fcomponents%2FComponentB.vue)

Not sure about the `key` issue. I'm wondering if ``'s `key` is supposed to be automatically applied to `` children. Nothing in the [docs](https://vuejs.org/guide/essentials/list.html#maintaining-state-with-key) suggests the `key` should be manually/explicitly...