[LOGBACK-1019] Added code to close the DatagramSocket

[nrkkalyan]

I am surprised to see there is no close method called on the DatagramSocket this may lead to a UDP leak. Kindly let me know if there is anything wrong in my code.

[nrkkalyan]

Can you please let me know why does the build failed, as I tried to build the same way and everything went successful

[huxi]

It says

Tests in error:

JettyBasicTest.postContentConverter:123 » IndexOutOfBounds Index: 0, Size: 0

in the output. You can find that output if you click on Details in the Travis message.

[davidkarlsen]

It's probably due to

synchronized (listAppender) {
  listAppender.wait(100); //this depends on how fast the computer running the test is...
}

[adlawson]

Is this fix related to an issue I'm currently seeing?

|-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [syslog]
|-WARN in ch.qos.logback.classic.net.SyslogAppender[syslog] - Failed to bind to a random datagram socket. Will try to reconnect later. java.net.SocketException: maximum number of DatagramSockets reached
    at java.net.SocketException: maximum number of DatagramSockets reached

It would be great to get this merged in if it is!

[nrkkalyan]

Yes it is.

Regards /Kalyan 0733312584

PS: I am bad at spelling because I use mobile.

On 9 feb 2015, at 13:03, Andrew Lawson [email protected] wrote:

Is this fix related to the issue I'm currently seeing?

|-INFO in ch.qos.logback.core.joran.action.AppenderAction - Naming appender as [syslog] |-WARN in ch.qos.logback.classic.net.SyslogAppender[syslog] - Failed to bind to a random datagram socket. Will try to reconnect later. java.net.SocketException: maximum number of DatagramSockets reached at java.net.SocketException: maximum number of DatagramSockets reached It would be great to get this merged in if it is!

— Reply to this email directly or view it on GitHub.

[adlawson]

This is becoming a pretty serious blocker for us now. Are there any contributors available to get this reviewed and released?

[tony19]

Thanks for the contribution, @nrkkalyan. Please add a comment here with release notes (see rule P7 of CONTRIBUTING.md).

[tony19]

I was actually looking for raw HTML that describes your change, which would be added to the release notes page.

[nrkkalyan]

RELEASE COMMENT

<p>Fixed <a href="http://jira.qos.ch/browse/LOGBACK-1019">LOGBACK-1019</a> 
      SyslogAppender leaks file descriptors. by Radhakrishna Kalyan Nimmagadda.
      Thanks to Fadi Mohsen for creating the Jira ticket.
</p>

[nrkkalyan]

Hi, I would like to know why my commit has not yet pulled and merged to the head. Am I missing anything. Kindly let me know.

[tony19]

@nrkkalyan, looks like there's a comment you haven't addressed.

@ceki, please review this PR.

[nrkkalyan]

Hi Please let me know if my release comment above is properly written by me.

[nrkkalyan]

Hi

I would like to know when can I expect my changes merged to the head version.

Thanks in advance

[Jay-JS]

Is this PR merged? It is causing some serious issue of intermittent failure and UDP leak. Please respond. Thanks!!

[Jay-JS]

Hi @tony19 @ceki are there any issues with this PR? Why this one is not getting merged. It is causing some serious issues. do we have any plan to resolve this?