Tõnis Tiigi

Results 98 issues of Tõnis Tiigi

~depends on #4931 (only last commit new)~ This does not cover all warnings yet but split into chunks to ease review. There are quite a lot of updates needed so...

status/code-review

Detect the case where the resolved base image does not match the expected platform from request. This can happen in two main cases: - Single arch image manifest for a...

status/code-review

Improve the error messages for error messages if FROM flags if they are caused by mismatched variables. Additional commits improve the messages for UndeclaredArgInFrom and UndefinedVar warnings. Example: ``` Dockerfile:1...

status/code-review

Check that the result returned from the frontend matches the user request conventions and show a warning if it doesn't. I'll be following up to this with verification on image...

kind/enhancement
status/code-review
needs/follow-up

We have many reports that end() gets called without the span being defined in start() and causes a panic. Ref https://github.com/moby/buildkit/issues/4377 Ref https://github.com/docker/buildx/issues/2232 I have not not fully debugged in...

fixes #5088 Avoid putting big error metadata to main history record and instead write it to a separate blob.

Currently some rules show up for `FROM` lines that are not part of the active target. They can be stored and only reported in the `dispatch()` state where it is...

area/dockerfile

``` === FAIL: frontend/dockerfile TestIntegration/TestUndeclaredArg/worker=oci-rootless/frontend=gateway/warntype=progress#05 (1.14s) dockerfile_lint_test.go:1076: Error Trace: /src/frontend/dockerfile/dockerfile_lint_test.go:1037 /src/frontend/dockerfile/dockerfile_lint_test.go:1076 Error: Not equal: expected: 1 actual : 2 Test: TestIntegration/TestUndeclaredArg/worker=oci-rootless/frontend=gateway/warntype=progress#05 --- FAIL: TestIntegration/TestUndeclaredArg/worker=oci-rootless/frontend=gateway/warntype=progress#05 (1.14s) ``` This happens because additional...

area/dockerfile
area/testing

The history API record contains a nice typed error atm https://github.com/moby/buildkit/blob/v0.14.1/api/services/control/control.proto#L201 retaining information like the stacktraces, source/vertex mapping etc. The problem is that for some errors this structure can grow...

kind/enhancement

When history record is saved after build completed, the OpenTelemetry trace is not saved initially and instead there is a 3 second sleep https://github.com/moby/buildkit/blob/v0.14.1/solver/llbsolver/solver.go#L402 before this process starts in the...