Toni Sevener
Toni Sevener
Hi @rajparad! Apologies for the review delay on this one. This all looks good from a code perspective - nice work! I will ask our designers to review further in...
@philherbert Thanks for taking this on! This looks good to me so far. Whenever you're ready you can mark this PR as Ready for Review.
@philherbert > docs/localization.md says Scripts will automatically create proper entries in qqq.json and related files. - despite building the app and running tests etc, I haven't seen any modifications to...
Hi @philherbert - we have plans on adjusting this summary view soon. I can merge this PR as-is, then we will tackle feedback from https://github.com/wikimedia/wikipedia-ios/pull/4745#issuecomment-1956840513 as a part of our...
> Hi @tonisevener - no objections here! Sorry that I forgot to update this, it very much fell through the cracks. No problem at all - thank you for working...
@lloydchang Thank you for fixing this! I have made a Phabricator [task](https://phabricator.wikimedia.org/T357323) to track this work and confirm the keyword changes.
These are looking good 👍
@b-onc Hello! Thank you for this PR. The team has agreed that this is a good improvement to pull into a near-future release. We are currently wrapping up a couple...
@b-onc Thanks for your patience. I found the web-side handling of this [here](https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/resources/src/mediawiki.special.createaccount/signup.js#62). I think this logic is close enough to our need to check your implementation against. Note here...
Hi @FilippoZazzeroni. Thanks for looking into this one, and my apologies for the long delay in review. Instead of creating a new set of Localizable.strings that translators will need to...