Tomek Niedźwiedź

Hello, my colleague ran into a funny situation using the Tag Maker. He accidentally uploaded a CRX Package to the ACS AEM Tools Tag Maker (version 0.0.40) instead of a...

Failure to recognise NOSONAR comments in HTL

1

Originally mentioned by @boobootoo2 and @bhartm3 in comments under https://github.com/wttech/AEM-Rules-for-SonarQube/issues/78 The comment below does not suppress the Sonar Error. I am able to suppress HTML issues however. ``` ```

Review the report: https://sonarcloud.io/dashboard?id=com.cognifide.aemrules%3Asonar-aemrules-plugin A few minor RegEx changes around operator precedence and a number of deprecated APIs to be replaced. Mostly detected in old code, with the introduction of...

Revise AEM-20 (ResourceResolver can be closed using try-with-resources Java 7 feature) Java 9+ support and possible redundancy.

1

During the code review of https://github.com/Cognifide/AEM-Rules-for-SonarQube/pull/181, we talked about try-with-resources statements and the implementation details of AEM-20 (ResourceResolver can be closed using try-with-resources Java 7 feature). We noticed a suspicious...

As per https://sling.apache.org/documentation/bundles/models.html#hints, the annotations `@Via`, `@Filter`, `@Named`, `@Optional`, `@Required`, `@Source` and `@Inject` have been replaced. Consider introducing a new rule to highlight their use and offer more modern suggestions.

While going over the Wiki and the markdown files, I ran into a few files that look like they're supposed to show examples and counterexamples of valid/invalid code. Examples: -...

As the team was working on the last release, there was a bit of a kerfuffle around transitive dependency versions, which consumed some of our time. Consider using the [Maven...

`data-sly-test` had been known as the only way to assign a value to an identifier for a long time until `data-sly-set` was introduced for that purpose. Valid use of `data-sly-test`:...

Sonar fixes

1

I analysed the code with SonarLint while looking for possible root causes of SLICE-140

The process of placing plugins in the SonarQube Marketplace is changing https://community.sonarsource.com/t/no-need-for-new-threads-for-plugin-updates/70351 https://community.sonarsource.com/t/deploying-to-the-marketplace/35236 This is a good moment to document the necessary steps in a `RELEASING.md` document.