tongust

Results 11 comments of tongust

## Benchmarks ### Test1: ![image](https://user-images.githubusercontent.com/13704175/166723656-0a9cee29-2cb6-43fb-afd4-1445df9f8fe0.png) ### Test2: ![image](https://user-images.githubusercontent.com/13704175/167457630-443ea0de-14c0-4b9f-be76-148a03491b9e.png) ### All reports in PDF: [all.pdf](https://github.com/maplibre/maplibre-gl-js/files/8653639/all.pdf) ### About the performance results of **HillshadeLoad** The scores were tested between product and my local...

> Looks interesting, thanks. Can you post the full CLI benchmark results? And can you ping me on slack? Updated all benchmark results in [above Benchmarks section](https://github.com/maplibre/maplibre-gl-js/pull/1191#issuecomment-1102879894).

> I'm not sure the name is intuitive, also I'm not sure I understand what it should solve. Can you elaborate a bit more about this? The triangles above are...

> @HarelM I think this feature is very important especially for lines as the current rendering is often not the desired effect. We have for example the use case of...

> Thanks for the information! Sorry for nagging, but in order to properly review this I need to better understand the design. So some questions and requests: > > 1....

> Regarding the style spec changes. #48 seems to be related (correct me if I'm wrong). I personally don't know about the use cases for other blending modes but this...

> I'm not sure how urgent this is. We can make PRs against this branch to better define the spec possibilities. I prefer to take the time and define the...

@HarelM @xabbu42 I have redesigned the spec for blending modes of draw fill. Currently it partially supports two modes: none (by default) and normal. Implementations of other blending modes are...

> I'm not sure from the name of the property and the options I understand what it does: comp-op is probably short for something (composition-operation?), I would advise against abbreviations......

> I believe this is good now. I'm happy with the new names. The only question remaining in this thread is the per-line support. Let me know how you would...