Marceau TONELLI
Marceau TONELLI
Hey, I'm willing to work on this 🙂
@Swiftb0y @ronso0 I've updated my implementation to take all your comments into consideration, I would recommend you look at the final result instead of going commit per commit as there...
@SimplyDanny Thanks for the review! After your comments I've rewrote the rule with a new approach that seems to be more flexible. Instead of visiting `VariableDeclSyntax` nodes I use `PatternBindingSyntax`...
> Looking at the OSS findings, most of them look valid. > > However, [there are cases](https://github.com/wordpress-mobile/WordPress-iOS/blob/12065e659d39e59a7e9a01a45caf31112dee49b8/WordPress/Classes/ViewRelated/Gutenberg/Collapsable%20Header/Collabsable%20Header%20Filter%20Bar/CollabsableHeaderFilterCollectionViewCell.swift#L83:26) where a sequence of MemberAccessExpressions leads to the final element/function. An easy example...
@mzeeshanid you could also check for type declarations (structs, enums, classes), and perhaps associated types and type aliases? Also idk if subscripts count as function declaration in SwiftSyntax but if...
Oh neat. Good one! 👏