Thomas Wearmouth comments

Results 6 comments of


                                            Thomas Wearmouth

Failure to delete temporary remapping file for any nested JAR in development environment

Through some initial triage, `0.15.4` seems to be the version that this started happening. From looking through the commits b2608bb is the likely candidate. My working theory is that the...

Failure to delete temporary remapping file for any nested JAR in development environment

While that commit is the problematic one, it turns out TinyRemapper isn't at fault here. The `RuntimeModRemapper#requiresMixinRemap(Path)` method is leading to the creation of `JarURLConnection` to read the manifest from...

Failure to delete temporary remapping file for any nested JAR in development environment

After some further experimentation - this has nothing specifically to do with FAPI either. It appears to affect any JAR loaded as a nested JAR through a `fabric.mod.json`. The most...

Fix failing to delete temporary remapping files

As discussed in the issue, I believe it might be a good idea to simply remove (or empty) the `tmp` directory used for remapping (if it exists) whenever the remapping...

Proposal for Performance Improvements in JDA Using fastutil and fastjson2

Agree on fastjson2, but fastutil is a massive library (~22MB). This is bigger than JDA + all its dependencies (including audio) is currently (~18MB). This should definitely be considered before...

running fill command causes ghost blocks in latest build

Not the dev, but here is the relevant WorldEdit API usage from the plugin in question: ```java com.sk89q.worldedit.world.World adaptedWorld = BukkitAdapter.adapt(world); RandomPattern pattern = new RandomPattern(); for (Map.Entry entry :...